use writableEnd instead finished #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phillip9587
approved these changes
Apr 28, 2025
UlisesGascon
approved these changes
Apr 29, 2025
10 tasks
Phillip9587
requested changes
May 11, 2025
Contributor
Phillip9587
left a comment
Phillip9587
left a comment
There was a problem hiding this comment.
I would prefer to use msg.writableEnded without a helper function as we plan to only support Node.js 18+ in v3.
Member
Author
|
@UlisesGascon @Phillip9587 I’d prefer to make this change for version 2, and it can be backported to v3. |
Phillip9587
approved these changes
May 12, 2025
Contributor
|
@bjohansebas Can you rebase the PR and remove the |
Member
Author
|
done, i’ve already done the rebase |
ctcpip
reviewed
Jul 24, 2025
ctcpip
reviewed
Jul 24, 2025
Co-authored-by: Chris de Almeida <[email protected]>
Co-authored-by: Chris de Almeida <[email protected]>
Phillip9587
approved these changes
Jul 24, 2025
ctcpip
approved these changes
Jul 24, 2025
Phillip9587
added a commit
to Phillip9587/on-finished
that referenced
this pull request
Aug 8, 2025
Phillip9587
added a commit
to Phillip9587/on-finished
that referenced
this pull request
Aug 8, 2025
…deprecated finished Ref: jshttp#54
Phillip9587
added a commit
to Phillip9587/on-finished
that referenced
this pull request
Aug 8, 2025
Phillip9587
added a commit
that referenced
this pull request
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is recommended to use that property over finished
https://nodejs.org/api/http.html#responsefinished
https://nodejs.org/api/deprecations.html#DEP0136
https://nodejs.org/api/http.html#requestwritableended