refactor: use stream.finished() instead of custom implementation

.github/workflows/ci.yml

@@ -1,13 +1,45 @@
 name: ci
 
 on:
-- pull_request
-- push
+  pull_request:
+    branches:
+      - master
+    paths-ignore:
+      - '*.md'
+  push:
+    paths-ignore:
+      - '*.md'
+
+permissions:
+  contents: read
+
+# Cancel in progress workflows
+# in the scenario where we already had a run going for that PR/branch/tag but then triggered a new run
+concurrency:
+  group: "${{ github.workflow }} ✨ ${{ github.event.pull_request.head.label || github.head_ref || github.ref }}"
+  cancel-in-progress: true
 
 jobs:
+  lint:
+    name: Lint
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: Setup Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: 'lts/*'
+
+      - name: Install dependencies
+        run: npm install --ignore-scripts --only=dev
+
+      - name: Run lint
+        run: npm run lint
+
   test:
     runs-on: ubuntu-latest
     strategy:
+      fail-fast: false
       matrix:
         name:
         - Node.js 0.8
@@ -34,6 +66,11 @@ jobs:
         - Node.js 16.x
         - Node.js 17.x
         - Node.js 18.x
+        - Node.js 19.x
+        - Node.js 20.x
+        - Node.js 21.x
+        - Node.js 22.x
+        - Node.js 23.x
 
         include:
         - name: Node.js 0.8
@@ -62,27 +99,27 @@ jobs:
           npm-i: [email protected] [email protected]
 
         - name: Node.js 4.x
-          node-version: "4.9"
+          node-version: "4"
           npm-i: [email protected] [email protected]
 
         - name: Node.js 5.x
-          node-version: "5.12"
+          node-version: "5"
           npm-i: [email protected] [email protected]
 
         - name: Node.js 6.x
-          node-version: "6.17"
-          npm-i: [email protected].2 [email protected]
+          node-version: "6"
+          npm-i: [email protected].3 [email protected]
 
         - name: Node.js 7.x
-          node-version: "7.10"
-          npm-i: [email protected].2 [email protected]
+          node-version: "7"
+          npm-i: [email protected].3 [email protected]
 
         - name: Node.js 8.0
           node-version: "8.0"
           npm-i: [email protected] [email protected]
 
         - name: Node.js 8.x
-          node-version: "8.17"
+          node-version: "8"
           npm-i: [email protected] [email protected]
 
         # test fail on Node.js 9.x for unknown reasons
@@ -91,38 +128,51 @@ jobs:
         #   node-version: "9.11"
         #   npm-i: [email protected] [email protected]
         - name: Node.js 10.x
-          node-version: "10.24"
+          node-version: "10"
           npm-i: [email protected]
 
         - name: Node.js 11.x
-          node-version: "11.15"
-          npm-i: mocha@9.2.2
+          node-version: "11"
+          npm-i: mocha@8.4.0
 
         - name: Node.js 12.x
-          node-version: "12.22"
-          npm-i: [email protected]
+          node-version: "12"
 
         - name: Node.js 13.x
-          node-version: "13.14"
+          node-version: "13"
 
         - name: Node.js 14.x
-          node-version: "14.19"
+          node-version: "14"
 
         - name: Node.js 15.x
-          node-version: "15.14"
+          node-version: "15"
 
         - name: Node.js 16.x
-          node-version: "16.15"
+          node-version: "16"
 
         - name: Node.js 17.x
-          node-version: "17.9"
+          node-version: "17"
 
         - name: Node.js 18.x
-          node-version: "18.1"
+          node-version: "18"
 
-    steps:
-    - uses: actions/checkout@v2
+        - name: Node.js 19.x
+          node-version: "19"
+
+        - name: Node.js 20.x
+          node-version: "20"
+
+        - name: Node.js 21.x
+          node-version: "21"
+
+        - name: Node.js 22.x
+          node-version: "22"
 
+        - name: Node.js 23.x
+          node-version: "23"
+
+    steps:
+    - uses: actions/checkout@v4
     - name: Install Node.js ${{ matrix.node-version }}
       shell: bash -eo pipefail -l {0}
       run: |
@@ -136,7 +186,12 @@ jobs:
         dirname "$(nvm which ${{ matrix.node-version }})" >> "$GITHUB_PATH"
 
     - name: Configure npm
-      run: npm config set shrinkwrap false
+      run: |
+        if [[ "$(npm config get package-lock)" == "true" ]]; then
+          npm config set package-lock false
+        else
+          npm config set shrinkwrap false
+        fi
 
     - name: Remove npm module(s) ${{ matrix.npm-rm }}
       run: npm rm --silent --save-dev ${{ matrix.npm-rm }}
@@ -150,8 +205,8 @@ jobs:
       shell: bash
       run: |
         # eslint for linting
-        # - remove on Node.js < 12
-        if [[ "$(cut -d. -f1 <<< "${{ matrix.node-version }}")" -lt 12 ]]; then
+        # - remove on Node.js < 10
+        if [[ "$(cut -d. -f1 <<< "${{ matrix.node-version }}")" -lt 10 ]]; then
           node -pe 'Object.keys(require("./package").devDependencies).join("\n")' | \
             grep -E '^eslint(-|$)' | \
             sort -r | \
@@ -175,53 +230,43 @@ jobs:
       run: |
         if npm -ps ls nyc | grep -q nyc; then
           npm run test-ci
-          cp coverage/lcov.info "coverage/${{ matrix.name }}.lcov"
         else
           npm test
         fi
 
-    - name: Lint code
-      if: steps.list_env.outputs.eslint != ''
-      run: npm run lint
-
-    - name: Collect code coverage
-      if: steps.list_env.outputs.nyc != ''
-      run: |
-        if [[ -d ./coverage ]]; then
-          mv ./coverage "./${{ matrix.name }}"
-          mkdir ./coverage
-          mv "./${{ matrix.name }}" "./coverage/${{ matrix.name }}"
-        fi
-
     - name: Upload code coverage
-      uses: actions/upload-artifact@v2
       if: steps.list_env.outputs.nyc != ''
+      uses: actions/upload-artifact@v4
       with:
-        name: coverage
-        path: ./coverage
+        name: coverage-node-${{ matrix.node-version }}
+        path: ./coverage/lcov.info
         retention-days: 1
 
   coverage:
     needs: test
     runs-on: ubuntu-latest
+    permissions:
+      contents: read
+      checks: write
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v4
 
     - name: Install lcov
       shell: bash
       run: sudo apt-get -y install lcov
 
     - name: Collect coverage reports
-      uses: actions/download-artifact@v2
+      uses: actions/download-artifact@v4
       with:
-        name: coverage
         path: ./coverage
+        pattern: coverage-node-*
 
     - name: Merge coverage reports
       shell: bash
-      run: find ./coverage -name lcov.info -exec printf '-a %q\n' {} \; | xargs lcov -o ./coverage/lcov.info
+      run: find ./coverage -name lcov.info -exec printf '-a %q\n' {} \; | xargs lcov -o ./lcov.info
 
     - name: Upload coverage report
-      uses: coverallsapp/github-action@master
+      uses: coverallsapp/github-action@v2
       with:
         github-token: ${{ secrets.GITHUB_TOKEN }}
+        file: ./lcov.info