Skip to content

Improve test coverage #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jshufro merged 8 commits into from
Apr 15, 2026
Merged

Improve test coverage #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
44840da
Simplyify domain calc to improve coverage
jshufro Apr 14, 2026
53ed06a
Refactor fork_info parsing into main sign handler
jshufro Apr 14, 2026
9bf550b
Add tests for new packages
jshufro Apr 14, 2026
888d82c
Improve coverage a bit
jshufro Apr 14, 2026
7c39fdf
Handle fork_info requirement in generated code
jshufro Apr 14, 2026
c4cde2c
Deduplicate a lot of logic
jshufro Apr 15, 2026
b4f330f
More DRY
jshufro Apr 15, 2026
4cbf71c
Further improve DRY adherence and coverage
jshufro Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion generate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ package main

//go:generate go run github.com/oapi-codegen/oapi-codegen/v2/cmd/oapi-codegen@v2.6.0 -config oapi-codegen/oapi-schemas.yaml remote-signing-api/signing/schemas.yaml
//go:generate go run github.com/oapi-codegen/oapi-codegen/v2/cmd/oapi-codegen@v2.6.0 -config oapi-codegen/oapi-codegen.yaml remote-signing-api/remote-signing-oapi.yaml
//go:generate go run ./signablegen generated remote-signing-api/signing/paths/sign.yaml generated/signables.gen.go
//go:generate go run ./signablegen remote-signing-api/signing/paths/sign.yaml generated generated/sign.gen.go api generated/api/signables-replacements.gen.go
4 changes: 2 additions & 2 deletions generated/remote_signing.gen.go → generated/api/remote_signing.gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions generated/schemas.gen.go → generated/api/schemas.gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 21 additions & 0 deletions generated/api/signables-replacements.gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

117 changes: 117 additions & 0 deletions generated/sign.gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

101 changes: 0 additions & 101 deletions generated/signables.gen.go
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import (
"syscall"

"github.com/jshufro/remote-signer-dirk-interop/config"
api "github.com/jshufro/remote-signer-dirk-interop/generated"
"github.com/jshufro/remote-signer-dirk-interop/generated/api"
"github.com/jshufro/remote-signer-dirk-interop/pkg/dirksigner"
"github.com/jshufro/remote-signer-dirk-interop/pkg/service"
tlsprovider "github.com/jshufro/remote-signer-dirk-interop/pkg/tls"
Expand Down
2 changes: 1 addition & 1 deletion oapi-codegen/oapi-codegen-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ generate:
client: true
output: client/remote_signing_client.gen.go
import-mapping:
../schemas.yaml: "github.com/jshufro/remote-signer-dirk-interop/generated"
../schemas.yaml: "github.com/jshufro/remote-signer-dirk-interop/generated/api"
output-options:
skip-prune: true
prefer-skip-optional-pointer: true
4 changes: 2 additions & 2 deletions oapi-codegen/oapi-codegen.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package: generated
package: api
generate:
models: true
std-http-server: true
output: generated/remote_signing.gen.go
output: generated/api/remote_signing.gen.go
import-mapping:
../schemas.yaml: "-"
output-options:
Expand Down
4 changes: 2 additions & 2 deletions oapi-codegen/oapi-schemas.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package: generated
package: api
generate:
models: true
output: generated/schemas.gen.go
output: generated/api/schemas.gen.go
output-options:
skip-prune: true
prefer-skip-optional-pointer: true
Expand Down
Loading
Loading