Fix https://github.com/jsk-ros-pkg/jsk_recognition/issues/2860 #2866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mqcmd196
force-pushed
the
fix-imagesift-segfault
branch
from
fbeae6a to
08ed039
Compare
|
|
CI green |
iory
approved these changes
Apr 28, 2025
|
can you compare calculation speed in single thread with and whitout this PR? because libsiftfast is originally developed to pursue high speed processing by several optimization technique, so I'd like to know how this changes the performance. |
What do you mean? Making the nodelet's num_worker_thread=1 or making the libsiftfast's OpenMP flag OFF? |
|
sorry |
…when more than 2 nodelets are loaded to the same nodelet manager
mqcmd196
force-pushed
the
fix-imagesift-segfault
branch
from
08ed039 to
1cfce13
Compare
|
I've tested the performance with launching With this PRWithout this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2860
libsiftfasthas so many static global variables, so it is not thread-safe when called from multiple nodelets. This PR adds a global mutex to restrict the access to those variables to make it thread-safe.Since the entire mutex is taken, if n imagesift nodelet are loaded, the time required to compute each feature is n times longer. But I think it is fine because the node is implemented with ConnectionBasedNodelet. If the user doesn't subscribe, the slow calculation doesn't occur. Making the user code work is much important.
The clean method is to make libsiftfast thread-safe, but I think we should write it from scratch or use OpenCV if we do so.
You can try the bug occurs just reverting 365b2d0 and execute
test_two_imagesift.test