-
Notifications
You must be signed in to change notification settings - Fork 96
[Fetch] add servo-off method to fetch-interface.l #1405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
k-okada
merged 15 commits into
jsk-ros-pkg:master
from
tkmtnt7000:PR-fetch-add-servo-off-master
Apr 26, 2022
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
a6fcf1d
add fetch servo-off method
tkmtnt7000 5551561
update variable define position
tkmtnt7000 dfa982d
controller-action --> fetch-controller-action
tkmtnt7000 d32c84f
add :servo-on method
tkmtnt7000 3941ccb
send current angle-vector to *fetch*
tkmtnt7000 eb6a7ee
add explanation of servo-on and servo-off method to README.md
tkmtnt7000 d246eb4
fix *ri* --> self
tkmtnt7000 aa676c3
start torso-controller when arm servo is on
tkmtnt7000 2654b9d
leave comment about servo-on
tkmtnt7000 d61e00a
set time as keyword option
tkmtnt7000 1e059b6
update default duration time of servo-on 200[msec]
tkmtnt7000 6bd1695
add docstring for servo-off and servo-on methods
tkmtnt7000 6200292
update README.md to add keyword option in servo-on method
tkmtnt7000 d0517ac
Merge branch 'master' into PR-fetch-add-servo-off-master
tkmtnt7000 1f6d329
Merge branch 'master' into PR-fetch-add-servo-off-master
k-okada File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tkmtnt7000 thank you, the last comment, please add method documentation like https://github.com/jsk-ros-pkg/jsk_pr2eus/blob/ca2d919fe87f61605c10c966af32dcdf8c4f5147/pr2eus/robot-interface.l#L378-L391
You can find better English explanation of each keyward...
If there is no reason for 500[msec], please set 200 or 300 as default. As you get used to robot experiments, you'll tend to set a lot of
sleep
and more duration time.c.f. https://youtu.be/8o0eU_O3_OY?t=982, https://www.mis.mpg.de/fileadmin/pdf/slides_al_2616.pdf (p.81), https://hlr2016.sciencesconf.org/data/hlr_2016_ta.pdf (p.39), https://www.codyco.eu/images/pdf/2013_Humanoids/Asfour.pdf (p.17)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for advice.
I understand speed is important.
I add the explanation of each keyword and the usage examples of these methods.