Skip to content

Conversation

@knorth55
Copy link
Member

@knorth55 knorth55 commented Jun 1, 2022

This PR fixes the build error in docker hub.

@knorth55 knorth55 changed the title install protobuf 3.18.0 for python2 install protobuf 3.18.0 for python2 in dockerfiles Jun 1, 2022
@knorth55 knorth55 closed this Jun 3, 2022
@knorth55 knorth55 reopened this Jun 3, 2022
@knorth55 knorth55 force-pushed the fix-docker-build branch 2 times, most recently from d79e8f9 to 1b954e4 Compare June 3, 2022 12:32
@knorth55
Copy link
Member Author

knorth55 commented Jun 3, 2022

all test passed, but travis failed.
I have no good idea to fix travis build error.
It is caused by protobuf version, but travis install chainer and protobuf with rosdep, not pip.

k-okada added a commit to k-okada/jsk_recognition that referenced this pull request Jun 8, 2022
```
https://files.pythonhosted.org/packages/6c/be/4e32d02bf08b8f76bf6e59f2a531690c1e4264530404501f3489ca975d9a/protobuf-4.21.0-py2.py3-none-any.whl (164kB)
2022-06-07T23:44:05.9270037Z protobuf requires Python '>=3.7' but the running Python is 2.7.17
2022-06-07T23:44:05.9270288Z You are using pip version 9.0.3, however version 22.1.2 is available.
2022-06-07T23:44:05.9270590Z You should consider upgrading via the 'pip install --upgrade pip' command.
```
k-okada added a commit to k-okada/jsk_recognition that referenced this pull request Jun 8, 2022
```
https://files.pythonhosted.org/packages/6c/be/4e32d02bf08b8f76bf6e59f2a531690c1e4264530404501f3489ca975d9a/protobuf-4.21.0-py2.py3-none-any.whl (164kB)
2022-06-07T23:44:05.9270037Z protobuf requires Python '>=3.7' but the running Python is 2.7.17
2022-06-07T23:44:05.9270288Z You are using pip version 9.0.3, however version 22.1.2 is available.
2022-06-07T23:44:05.9270590Z You should consider upgrading via the 'pip install --upgrade pip' command.
```
@mqcmd196
Copy link
Member

@knorth55 BTW, the official says 3.17.3 is the last python2.x release protocolbuffers/protobuf#8901 . Is it okay to install 3.18.0?

@knorth55
Copy link
Member Author

@mqcmd196 I didn't know the information! Thank you!

@knorth55 knorth55 changed the title install protobuf 3.18.0 for python2 in dockerfiles install protobuf 3.17.3 for python2 in dockerfiles Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants