Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a validation rule for content_type pin.image #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add a validation rule for content_type pin.image #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ gem 'coffee-rails', '~> 4.2'
gem 'jquery-rails'# Turbolinks makes navigating your web application faster. Read more: https://github.com/turbolinks/turbolinks
gem 'turbolinks', '~> 5'
gem 'jbuilder', '~> 2.5'
gem 'bootstrap-sass'
gem 'bootstrap-sass', '~> 3.2.0'
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes your code more portable, as you need bootstrap 3 to run it. On systems that have an older version installed, your app will see that bootstrap is already installed but then will hit errors when it runs.

gem 'devise'
gem 'paperclip', '~> 4.2'

Expand Down
1 change: 1 addition & 0 deletions app/models/pin.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
class Pin < ActiveRecord::Base
belongs_to :user
has_attached_file :image, :styles => { :medium => "300x300>", :thumb => "100x100>" }
validates_attachment_content_type :image, :content_type => ["image/jpg", "image/jpeg", "image/png", "image/gif"]
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the validation rule which checks that the file being uploaded has one of the standard image content-types, so that someone would be prevented from uploaded a pdf for example. You'd probably want to add additional validation rules, like on the max file size, for example.

end
1 change: 1 addition & 0 deletions app/views/pins/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<p id="notice"><%= notice %></p>

<p>
<%= link_to image_tag(@pin.image.url, class: 'media-object'), @pin.image.url, target: '_blank' %>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just to test that the image upload was working. You'd probably want to display a thumbnail version of the image instead what this is doing, which is showing the original.

<strong>Description:</strong>
<%= @pin.description %>
</p>
Expand Down