Partially revert changes for CA1873 (expensive logging) #1904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be expensive and unnecessary if logging is disabled), now that it's not so rigid anymore since .NET 10 SDK v10.0.102
bkoelman
force-pushed
the
partially-revert-CA1873
branch
from
2b97efd to
72c0edb
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1904 +/- ##
==========================================
- Coverage 92.24% 92.24% -0.01%
==========================================
Files 437 437
Lines 14860 14858 -2
Branches 2451 2450 -1
==========================================
- Hits 13708 13706 -2
Misses 709 709
Partials 443 443 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially revert changes for CA1873 ("Evaluation of this argument may be expensive and unnecessary if logging is disabled"), now that it's not so rigid anymore since .NET 10 SDK v10.0.102.
QUALITY CHECKLIST