add test for arbitrary URI in $id (#797)#798
Open
sangamon wants to merge 2 commits intojson-schema-org:mainfrom
Open
add test for arbitrary URI in $id (#797)#798sangamon wants to merge 2 commits intojson-schema-org:mainfrom
sangamon wants to merge 2 commits intojson-schema-org:mainfrom
Conversation
jdesrosiers
reviewed
Nov 25, 2025
Member
jdesrosiers
left a comment
jdesrosiers
left a comment
There was a problem hiding this comment.
We already have tests covering multiple non-http URI schemes including urn: and file:. Do we really need another? I don't think we want to include tests for every known URI scheme. I think it's sufficient to have one or two examples.
sangamon
changed the title
jdesrosiers
reviewed
Feb 11, 2026
Member
jdesrosiers
left a comment
jdesrosiers
left a comment
There was a problem hiding this comment.
Sorry, this seems to have slipped through the cracks.
I looks like the consensus in the end was to include urn:, tag:, and something arbitrary like foo:. Could you bring back your original tag: tests and keep these so we're covering all three cases.
| ] | ||
| }, | ||
| { | ||
| "description": "simple custom URI base URI with $ref via the custom URI", |
Member
There was a problem hiding this comment.
I think this description needs to be more clear about what's "custom" is the URI scheme. Here's my suggestion.
Suggested change
| "description": "simple custom URI base URI with $ref via the custom URI", | |
| "description": "simple base URI using an arbitrary URI scheme with $ref to that URI", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
naive copy of test cases for URN in
$idwith tag URI values for issue #797