fix: align test description with actual valid field in maximum.json across drafts#851
Merged
jdesrosiers merged 2 commits intojson-schema-org:mainfrom Feb 25, 2026
Conversation
jdesrosiers
requested changes
Feb 24, 2026
Member
jdesrosiers
left a comment
jdesrosiers
left a comment
There was a problem hiding this comment.
Can you add this to the v1 test too.
Contributor
Author
|
jdesrosiers
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test case for 299.97 with maximum: 300 has valid: true but its
description incorrectly says "below the maximum is invalid" —
it should say "below the maximum is valid".
Fixed across all affected drafts.