Skip to content

feat: add structure/ tests for draft2019-09 and draft2020-12#864

Open
Sagar-6203620715 wants to merge 2 commits intojson-schema-org:mainfrom
Sagar-6203620715:feat/add-output-structure-test
Open

feat: add structure/ tests for draft2019-09 and draft2020-12#864
Sagar-6203620715 wants to merge 2 commits intojson-schema-org:mainfrom
Sagar-6203620715:feat/add-output-structure-test

Conversation

@Sagar-6203620715
Copy link

@Sagar-6203620715 Sagar-6203620715 commented Mar 7, 2026

The output-tests/README.md documents two test categories content/ and structure/structure/ subdirectory was never created for either draft. A TODO comment in the README confirms this is a known gap.

This PR adds 8 new files across draft2020-12/structure/ and draft2019-09/structure/:

File Verifies
flag.json Output contains only valid, no extra keys
basic.json errors array shape; uses anyOf: [true] to avoid single-output-unit ambiguity
detailed.json Nested errors structure via allOf
verbose.json annotations array present for all evaluated keywords

All 8 files pass JSON validation and output-test-schema.json conformance. No new failures introduced in bin/jsonschema_suite check.

Closes #863

Signed-off-by: Sagar-6203620715 <sagar6203620715@gmail.com>
@Sagar-6203620715 Sagar-6203620715 requested a review from a team as a code owner March 7, 2026 06:42
Signed-off-by: Sagar-6203620715 <sagar6203620715@gmail.com>
@Sagar-6203620715
Copy link
Author

/cc @jdesrosiers
Please review !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Coverage] output-tests/ is missing structure/ subdirectory documented in README

1 participant