fix: remove duplicate allOf and maxItems entries in draft2020-12 KNOW…#865
Open
Sagar-6203620715 wants to merge 1 commit intojson-schema-org:mainfrom
Open
fix: remove duplicate allOf and maxItems entries in draft2020-12 KNOW…#865Sagar-6203620715 wants to merge 1 commit intojson-schema-org:mainfrom
Sagar-6203620715 wants to merge 1 commit intojson-schema-org:mainfrom
Conversation
…N set Signed-off-by: Sagar Choudhary <sagar6203620715@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
bin/jsonschema_suite, the"draft2020-12"block of theKNOWNdict has"allOf"and"maxItems"each listed twice on consecutive lines (283–284, 303–304). Python sets deduplicate silently so behaviour is unaffected, but the redundancy is misleading to readers and a hazard if the structure is ever changed to a list.Fix: remove one instance of each duplicate in the
"draft2020-12"block only. No other draft blocks are affected. Verified withtox.