Make ResourceIdentifier.type/id/toDictionary() public access level. #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to this old PR on the original Spine repo, it would be nice to consider keeping the setter private, and only expose the getter from the outside. What do you think ? |
Author
|
Yep, that would suffice, and way safer:). |
|
Sounds good! 😊 |
|
And thanks for this PR! |
Author
|
Thank you guys, and credit goes to you for taking the initiative to maintain Spine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change access level of
ResourceIdentifier.type,ResourceIdentifier.idandResourceIdentifier.toDictionary()from internal to public, to give access to other modules.