OpenFeatureOperator CRDs library#482
Open
anatolPavl wants to merge 4 commits intojsonnet-libs:masterfrom
Open
Conversation
Contributor
anatolPavl
commented
Nov 21, 2024
anatolPavl
commented
- Merged in hotfix for Bug-307 <- PR: PR for Fix only
- Added config.jsonnet to generate libs for the OpenFeatureOperator CRDs
xvzf
approved these changes
Dec 5, 2024
Member
xvzf
left a comment
xvzf
left a comment
There was a problem hiding this comment.
lgtm, thanks for the contribution
xvzf
reviewed
Dec 5, 2024
Comment on lines
+125
to
+135
| func removeStringsWithDollar(input []string) []string { | ||
| var result []string | ||
| for _, str := range input { | ||
| if !strings.Contains(str, "$") { | ||
| result = append(result, str) | ||
| } else { | ||
| log.Default().Printf("Warning: %s contains a '$' and has been ommited from final libsonnet as a temporary fix", str) | ||
| } | ||
| } | ||
| return result | ||
| } |
Member
There was a problem hiding this comment.
Before merging I'll check if this has some side-effects, will be busy the next week but should have time after
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.