feat: Support multiple container runtimes#623
Open
juliajohannesen wants to merge 1 commit intojsonnet-libs:masterfrom
Open
feat: Support multiple container runtimes#623juliajohannesen wants to merge 1 commit intojsonnet-libs:masterfrom
juliajohannesen wants to merge 1 commit intojsonnet-libs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #618 and adds functionality to the existing build scripts to support building via other container runtimes, namely podman.
In podman, the container will run as root, as this will be remapped by the kernel thanks to namespacing arguments, and is required to properly access host files not owned by the container. I'm not 100% certain if other alternative container runtimes support this feature, so I'm leaving it as a podman-only override for now.
To run any make command using podman, you can run
make -e RUNTIME=podman.