Add tests for consecutive ands and ors in filter. Resolves #111 #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f3ath
requested changes
Oct 15, 2025
tests/filter.json
Outdated
| } | ||
| ], | ||
| "result_paths": [ | ||
| "$[6]" |
Collaborator
There was a problem hiding this comment.
This should be $[3] I believe.
Contributor
Author
There was a problem hiding this comment.
your belief is right. That's my b, thought I went back to update this one after testing. Also fixed b in one of the test cases being 2 instead of 1.
jarangutan
force-pushed
the
multiple-ands-ors
branch
from
db1dc0a to
3c665dd
Compare
jarangutan
force-pushed
the
multiple-ands-ors
branch
from
3c665dd to
0b1991c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests to handle multiple consecutive ands, ors and ands/ors together.
I wasn't sure what to tag these with so I placed them right on top of the other base tests in filter.json. Is there a tag these should ideally go under?