Test quoted false positive of incorrect capitalization #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f3ath
reviewed
Nov 21, 2025
| { | ||
| "a": "True" | ||
| }, | ||
| { |
Collaborator
There was a problem hiding this comment.
Would it make sense to add an entry like
{
"a": true
}and similar ones to the other tests?
Contributor
Author
There was a problem hiding this comment.
Good idea, can't hurt. Added.
TamasSzigeti
force-pushed
the
capitalisation-false-positives
branch
from
eb1da1c to
a17a1f3
Compare
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Nov 29, 2025
…igeti) This PR was merged into the 7.3 branch. Discussion ---------- [JsonPath] Fix throwing on quoted True/False/Null | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | License | MIT Bumped into this when parsing Kubernetes json output where `"True"` is commonly used and JsonPath threw for this valid expression. Making the regex more strict fixes it. See also [PR for upstream fixtures](jsonpath-standard/jsonpath-compliance-test-suite#113) Commits ------- d761e25 Fix JsonPath throwing on quoted True/False/Null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up in the Symfony implementation, I was told it might be useful upstream too