Skip to content
This repository was archived by the owner on Jun 12, 2026. It is now read-only.

feat: remove "browsersync: connected" banner#529

Closed
bagage wants to merge 1 commit into
jsonresume:masterfrom
bagage:patch-1
Closed

feat: remove "browsersync: connected" banner#529
bagage wants to merge 1 commit into
jsonresume:masterfrom
bagage:patch-1

Conversation

@bagage

@bagage bagage commented Mar 5, 2021

Copy link
Copy Markdown

Cf https://browsersync.io/docs/options#option-notify, this banner doesn't bring much value and when you use chrome native PDF export (my theme isn't working great with resume export), this banner gets exported too (to avoid that you have to add a delay before exporting, which is not ideal IMHO).

@thomasdavis

Copy link
Copy Markdown
Member

@bagage thanks — silencing the "Connected to BrowserSync" banner is a small but real quality-of-life touch for resume serve. One-line change, easy to port to packages/cli if you'd like it to live on.

Here's the context: JSON Resume is under active maintenance again (2026), and resume-cli has been revived — but the codebase moved into the jsonresume.org monorepo at packages/cli (merged in jsonresume/jsonresume.org#278). This standalone repo is being archived with a redirect, so PRs against it can no longer land — which is why I'm closing this rather than merging it.

If the change still matters to you, we'd genuinely welcome a re-submission against packages/cli in the monorepo — the maintainers are active there and PRs get reviewed. Announcement: #786 · Consolidation: jsonresume/jsonresume.org#275. Thanks again for contributing during the years when this repo was quiet — it didn't go unnoticed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants