feat(export): allow setting paper size in pdf export#728
Conversation
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (5)
lib/export-resume.js:11
- [nitpick] The parameter name 'papersize' should be renamed to 'paperSize' to follow camelCase convention.
{ resume: resumeJson, fileName, theme, format, papersize },
lib/export-resume.js:31
- [nitpick] The parameter name 'papersize' should be renamed to 'paperSize' to follow camelCase convention.
createPdf(resumeJson, fileName, theme, formatToUse, papersize, (error) => {
lib/export-resume.js:84
- [nitpick] The parameter name 'papersize' should be renamed to 'paperSize' to follow camelCase convention.
papersize,
lib/export-resume.js:117
- [nitpick] The parameter name 'papersize' should be renamed to 'paperSize' to follow camelCase convention.
format: papersize,
lib/export-resume.js:11
- Ensure that the new 'papersize' option is covered by tests to verify it works as expected.
{ resume: resumeJson, fileName, theme, format, papersize },
|
@Galaxy102 thank you for this — a Here's the context: JSON Resume is under active maintenance again (2026), and resume-cli has been revived — but the codebase moved into the jsonresume.org monorepo at If the change still matters to you, we'd genuinely welcome a re-submission against |
Hello,
for non-US fellas using Letter as paper format is pretty uncommon. Thus I thought it would be great if you could pass the PDF paper size as an option.
Please let me know about anything improvable, Javascript is not my main programming language.
Cheers!