Skip to content
This repository was archived by the owner on Jun 12, 2026. It is now read-only.

feat(export): allow setting paper size in pdf export#728

Closed
Galaxy102 wants to merge 1 commit into
jsonresume:masterfrom
Galaxy102:paper-format
Closed

feat(export): allow setting paper size in pdf export#728
Galaxy102 wants to merge 1 commit into
jsonresume:masterfrom
Galaxy102:paper-format

Conversation

@Galaxy102

Copy link
Copy Markdown

Hello,

for non-US fellas using Letter as paper format is pretty uncommon. Thus I thought it would be great if you could pass the PDF paper size as an option.

Please let me know about anything improvable, Javascript is not my main programming language.

Cheers!

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (5)

lib/export-resume.js:11

  • [nitpick] The parameter name 'papersize' should be renamed to 'paperSize' to follow camelCase convention.
{ resume: resumeJson, fileName, theme, format, papersize },

lib/export-resume.js:31

  • [nitpick] The parameter name 'papersize' should be renamed to 'paperSize' to follow camelCase convention.
createPdf(resumeJson, fileName, theme, formatToUse, papersize, (error) => {

lib/export-resume.js:84

  • [nitpick] The parameter name 'papersize' should be renamed to 'paperSize' to follow camelCase convention.
papersize,

lib/export-resume.js:117

  • [nitpick] The parameter name 'papersize' should be renamed to 'paperSize' to follow camelCase convention.
format: papersize,

lib/export-resume.js:11

  • Ensure that the new 'papersize' option is covered by tests to verify it works as expected.
{ resume: resumeJson, fileName, theme, format, papersize },

@thomasdavis

Copy link
Copy Markdown
Member

@Galaxy102 thank you for this — a --papersize flag for PDF export is a clean, well-scoped feature (the hardcoded Letter default has annoyed A4 users for years), and your implementation threading it through to page.pdf() is exactly right. This is one of the PRs from this repo most worth porting forward.

Here's the context: JSON Resume is under active maintenance again (2026), and resume-cli has been revived — but the codebase moved into the jsonresume.org monorepo at packages/cli (merged in jsonresume/jsonresume.org#278). This standalone repo is being archived with a redirect, so PRs against it can no longer land — which is why I'm closing this rather than merging it.

If the change still matters to you, we'd genuinely welcome a re-submission against packages/cli in the monorepo — the maintainers are active there and PRs get reviewed. Announcement: #786 · Consolidation: jsonresume/jsonresume.org#275. Thanks again for contributing during the years when this repo was quiet — it didn't go unnoticed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants