Skip to content

let contrib repo import json files as modules #3401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 29, 2024
Merged

let contrib repo import json files as modules #3401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db7bcf8
let contrib repo import json files as modules
jadeddelta Sep 22, 2024
b420804
consolidate resolveJsonModule rule into main tsconfig.json
jadeddelta Oct 19, 2024
34c0e54
update comment style
jadeddelta Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/eight-steaks-camp.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@jspsych/config": patch
---

allow JSON resolution in contrib repository for usage of package.json in versioning
2 changes: 1 addition & 1 deletion packages/config/tsconfig.contrib.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@
"paths": {
// map jspsych-contrib package imports directly to their source files
"@jspsych-contrib/*": ["../*/src"]
}
},
}
}
2 changes: 0 additions & 2 deletions packages/config/tsconfig.core.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,5 @@
"jspsych": ["../jspsych/src"],
"@jspsych/*": ["../*/src"]
},
// allow resolving json modules in tests (needed for transitive imports of jspsych)
"resolveJsonModule": true
}
}
3 changes: 2 additions & 1 deletion packages/config/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
"skipLibCheck": true,
"forceConsistentCasingInFileNames": true,
"noEmit": true,
"isolatedModules": true // required by Sucrase
"isolatedModules": true, // required by Sucrase
"resolveJsonModule": true, // required for automatic package versioning and needed for transitive imports of jspsych
}
}
Loading