Skip to content

fix: enable_button_after parameter in plugin-image-button-response (closes #3562) #3563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 18, 2025
Merged

fix: enable_button_after parameter in plugin-image-button-response (closes #3562) #3563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d1da5bf
fix(image-button-response): reverted everything and recomitting only …
farhat60 Jul 9, 2025
ac06fc9
test(plugin-image-button-response): enable_button_after. Failed witho…
farhat60 Jul 9, 2025
c66b8ad
revert test
farhat60 Jul 9, 2025
0eb7332
fix(test): delay enable button queries the right css selector now
farhat60 Jul 9, 2025
d2616fc
Update index.spec.ts
farhat60 Jul 9, 2025
c902be3
changeset
farhat60 Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/busy-tires-reply.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@jspsych/plugin-image-button-response": minor
---

CSS selector that queries the button to disable it was trying to get a class. Now it looks for the correct id and disables the button.
2 changes: 1 addition & 1 deletion packages/plugin-image-button-response/src/index.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ describe("image-button-response", () => {
},
]);

const btns = displayElement.querySelectorAll(".jspsych-image-button-response-button button");
const btns = displayElement.querySelectorAll("#jspsych-image-button-response-btngroup button");

for (let i = 0; i < btns.length; i++) {
expect(btns[i].getAttribute("disabled")).toBe("disabled");
Expand Down
4 changes: 2 additions & 2 deletions packages/plugin-image-button-response/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,14 +306,14 @@ class ImageButtonResponsePlugin implements JsPsychPlugin<Info> {
}

function enable_buttons() {
var btns = document.querySelectorAll(".jspsych-image-button-response-button button");
var btns = document.querySelectorAll("#jspsych-image-button-response-btngroup button");
for (var i = 0; i < btns.length; i++) {
btns[i].removeAttribute("disabled");
}
}

function disable_buttons() {
var btns = document.querySelectorAll(".jspsych-image-button-response-button button");
var btns = document.querySelectorAll("#jspsych-image-button-response-btngroup button");
for (var i = 0; i < btns.length; i++) {
btns[i].setAttribute("disabled", "disabled");
}
Expand Down