Fix broken examples: replace jsPsych.timelineVariable with evaluateTimelineVariable in parameter functions #3614
+8
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two example files that were incorrectly using
jsPsych.timelineVariable()
inside parameter functions. According to jsPsych best practices,jsPsych.evaluateTimelineVariable()
should be used when referencing timeline variables within functions, as it immediately evaluates the variable's current value, whilejsPsych.timelineVariable()
creates a placeholder for delayed evaluation.Changes
examples/jspsych-canvas-keyboard-response.html
jsPsych.timelineVariable()
withjsPsych.evaluateTimelineVariable()
inside thestimulus
functionBefore:
After:
examples/timeline-variables.html
jsPsych.timelineVariable('v2', true)
withjsPsych.evaluateTimelineVariable('v2')
inside theprompt
functionBefore:
After:
Verification
jspsych-canvas-button-response.html
Fixes #[issue number]
Original prompt
Fixes #3613
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.