-
Notifications
You must be signed in to change notification settings - Fork 80
Maze plugin #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Maze plugin #176
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey, thanks for the contribution! really appreciate it, though i do have two structural questions:
-
plugins should try to be as atomic as possible, completing one task- so i'm wondering if it's worth keeping the comprehension
question
parameter and functionality, instead opting for something like having aplugin-html-button-response
orplugin-html-keyboard-response
that the developer can use instead of being forced to use this (can also make it clear to use comprehension examples via the example) -
is canvas the best solution for this? i only bring this up as i'm personally working on a new version of a self-paced reading plugin (#145) that uses the DOM and placing the words via paragraph elements without using a canvas. it allows for developers to use CSS to style the text themselves, along with being very supportive of multiple browser sizes (and mobile) without having to change canvas parameters. would it be possible to bring that to this plugin? or rather- if we want to keep this implementation, we could have an
plugin-canvas-maze
and anplugin-html-maze
as well? just wondering your thoughts, and if you have any thoughts @jodeleeuw as well?
Thanks for the quick review!
So that's one thought I had, in the end I chose to still have an integrated facility for the questions, my rationale being that it makes it a lot easier to have consistent style and placement, and if the developer wants to use something else, they can leave the question undefined in maze and handle it separately. So mostly the idea is quality of life, but I'm of course very open to remove it :-)
Oh good points! I took the canvas idea from the current SPR, assuming that the choice was maybe for reactivity and precise positioning, but now that I think of it, it makes sense to me to change to DOM, so yes, I'll do that. So. Back to the coding board I go! |
awesome! thank you, and feel free to use details from my implementation in that PR that i mentioned (it's under SPR mode 3) and as for the |
Noted! I'll be pushing some extra changes to tweak the functionalities as we are dogfooding the canvas version to make sure we get the interface just right, but the switch to DOM is underway in parallel, I'll ping you with a review request once it's done :) |
changes the end data in an annoying way
Switch maze to DOM
This means to add a jsPsych plugin for running Maze (Forster et al., 2009) experiments, a version of self-paced
reading that asks to chose between the correct next word and a distractor. I have put together a small demo.
This is currently in a functional state, with very basic tests that check loading and running through one trial (but are by no mean exhaustive). I would love to get this included and I'm willing to keep maintaining it for the foreseeable future. Please tell me if there's anything that needs doing :-)