-
Notifications
You must be signed in to change notification settings - Fork 134
feat(frontend): add option to unstack downloads per version #1101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing this, it was really confusing
this is intentional behaviour, and is common across other systems already (ie crates.io). a stacked graph makes sense for an aggregation set of data across different points, so this seems the right usecase |
ah dangit |
@tylersayshi yes that sounds good |
out = new Date(Date.UTC( | ||
date.getUTCFullYear(), | ||
date.getUTCMonth(), | ||
date.getUTCDate() - date.getUTCDay(), | ||
)); | ||
out = new Date( | ||
Date.UTC( | ||
date.getUTCFullYear(), | ||
date.getUTCMonth(), | ||
date.getUTCDate() - date.getUTCDay(), | ||
), | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why might this change? I ran deno fmt
, is the style not guarenteed to stay the same?
const isDarkMode = document.documentElement.classList.contains( | ||
"dark", | ||
); | ||
const newAggregationPeriod = e.currentTarget | ||
.value as AggregationPeriod; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
took the chance to simplify this logic while I was reading it and adding the other select.
only updateSeries is needed for this
adds option to view stacked and unstacked downloads (keeping current defaults). Replicating the downloads chart for crates.io
stacked:

unstacked:

options on small screens:
