Skip to content

Conversation

@bhavanesh2001
Copy link

Description of change

This PR adds default brush initialization to several controls that previously lacked them. Without defined brushes or colors, some controls — such as the Slider — were not rendering at all.

If i define controls something like this

 <controls:Slider />
 <controls:ToggleSwitch />
 <controls:SegmentedControl>
   <controls:SegmentedControl.ItemsSource>
     <x:Array Type="{x:Type x:String}">
       <x:String>Option 1</x:String>
       <x:String>Option 2</x:String>
       <x:String>Option 3</x:String>
     </x:Array>
   </controls:SegmentedControl.ItemsSource>
 </controls:SegmentedControl>
 <controls:NumericUpDown  />
 <controls:LinearGauge Value="50"  />

The slider is not visible at all, and other controls have issues too..

Mobile Screenshot

After Fix

Mobile Screenshot

Fixes #64


public static readonly new BindableProperty BackgroundProperty =
BindableProperty.Create(nameof(Background), typeof(Brush), typeof(Button), null,
BindableProperty.Create(nameof(Background), typeof(Brush), typeof(Button), new SolidColorBrush(Colors.Pink),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you create a static class where define the Controls Themes with colors etc?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Slider is not visible in Android

2 participants