Fix CI pipeline: correct package names, install deps#1
Merged
Conversation
- Fix headless check: arcane-core → arcane-engine (correct crate name) - Fix Rust tests: use `cargo test --workspace` with ALSA libs (CLI always builds with renderer features, needs libasound2-dev) - Fix V8 tests: install ALSA libs, drop --no-default-features (flag had no effect since CLI hardcodes renderer feature) - Fix declarations check: install typescript globally before npx tsc Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Gate render bridge methods with #[cfg(feature = "renderer")] so `cargo check -p arcane-engine --no-default-features` compiles - Install npm deps before generate-declarations.sh (needs @types/node) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Fix generate-declarations.sh: use `npx -p typescript tsc` to avoid the wrong `tsc` npm package - Add npm install to V8 test job (needs @types/node for type checking) - Add setup-node to V8 test job Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jsvd
added a commit
that referenced
this pull request
Feb 27, 2026
…ile table Quick Start code block (60 lines) was fully covered by scaffold src/ files and existing AGENTS.md sections (Layer Map, Common Mistakes). File table repeated what scaffold file headers already say. Coordinate gotchas were duplicated in Common Mistakes #1, #2, #3. Net: -92 lines, zero information lost. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jsvd
added a commit
that referenced
this pull request
Feb 28, 2026
- Remove nonexistent autoCamera option from docs/entities.md createGame() docs - Fix arcane-api.md gotcha #1: camera (0,0) is top-left, not screen center - Fix rendertarget.ts JSDoc: main surface also uses top-left origin (not screen center) - Regenerate templates/default/types/rendering.d.ts Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
arcane-core→arcane-engine(correct crate name)cargo test --workspacewith ALSA libs (CLI always builds with renderer features, needslibasound2-dev)--no-default-features(flag had no effect since CLI hardcodes renderer feature)typescriptglobally beforenpx tscTest plan
🤖 Generated with Claude Code