fix(transloco): correct TRANSLOCO_MISSING_HANDLER token generic type#902
Open
arturovt wants to merge 1 commit intojsverse:masterfrom
Open
fix(transloco): correct TRANSLOCO_MISSING_HANDLER token generic type#902arturovt wants to merge 1 commit intojsverse:masterfrom
arturovt wants to merge 1 commit intojsverse:masterfrom
Conversation
The InjectionToken for TRANSLOCO_MISSING_HANDLER was typed as InjectionToken<TranslocoMissingHandlerData> instead of InjectionToken<TranslocoMissingHandler>. This caused a type mismatch when injecting the token into TranslocoService's constructor, which expects a TranslocoMissingHandler. The token now correctly reflects the shape of the value it provides.
@jsverse/transloco
@jsverse/transloco-locale
@jsverse/transloco-messageformat
@jsverse/transloco-optimize
@jsverse/transloco-persist-lang
@jsverse/transloco-persist-translations
@jsverse/transloco-preload-langs
@jsverse/transloco-schematics
@jsverse/transloco-scoped-libs
@jsverse/transloco-utils
@jsverse/transloco-validator
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The InjectionToken for TRANSLOCO_MISSING_HANDLER was typed as
InjectionToken<TranslocoMissingHandlerData>instead ofInjectionToken<TranslocoMissingHandler>.This caused a type mismatch when injecting the token into TranslocoService's constructor, which expects a TranslocoMissingHandler. The token now correctly reflects the shape of the value it provides.