[Fix] prop-types: props missing in validation when using ComponentPropsWithRef from a namespace import #3870
+324
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3870 +/- ##
==========================================
- Coverage 97.66% 97.58% -0.09%
==========================================
Files 136 133 -3
Lines 9978 9966 -12
Branches 3703 3703
==========================================
- Hits 9745 9725 -20
- Misses 233 241 +8 ☔ View full report in Codecov by Sentry. |
ljharb
force-pushed
the
prop-types-componentpropswithref
branch
from
b87bf7c to
90a00b9
Compare
ljharb
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3651.
Follows the pattern implemented in #3859 to prevent the
"is missing in props validation"error when using destructured props withComponentPropsWithRef.