Skip to content

Fix excel table area detection failures - #1309

Open
ccleva wants to merge 1 commit into
jtablesaw:masterfrom
ccleva:fix/excel_tablearea_detection
Open

ccleva wants to merge 1 commit into
jtablesaw:masterfrom
ccleva:fix/excel_tablearea_detection

Conversation

@ccleva

@ccleva ccleva commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

Thanks for contributing.

Description

Blank cells detection (used to identify the table area in excel sheets) did not take into account formulas and wrongly identified numerical 0 or false boolean as blank, leading to failed or incorrect table reading.

Fixes #1307

Testing

Added tests to confirm the issues. Tests are now passing with the fix.

@sonarqubecloud

sonarqubecloud Bot commented Apr 7, 2026

Copy link
Copy Markdown

@ccleva

ccleva commented Apr 7, 2026

Copy link
Copy Markdown
Contributor Author

Sonar complains about test methods being public, let me know if you prefer:

  • to keep the new methods public for consistency with the other test methods
  • to change the new test methods to package as recommended by Sonar
  • to change all test methods to package for consistency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

XLSX can't read 0

1 participant