feat: add padding for album name one have 1 character#6
Conversation
|
For the first problem, I just want to fix the album with only a single word. So maybe I can change the function from < 2 to == 1 that will be compatible with your case. |
5f80af1 to
70ed6e8
Compare
|
Besides, In RPC, only type watching and playing are allowed as described in link. |
YES! That's what I've been trying to explain on the other issue haha. Apologies for the slow reply. As for your new pull request, the issue persists. I have done some tests and have concluded that an empty string of just spaces will not be accepted by Discord RPC. May I suggest changing the display value of /**
* WORKS:
* undefined
*
* NOT WORKING
* ""
* false
*/
state: data.now_playing.three_line.line3.substr(0, 128) || undefined,We can choose to display something if |
|
Oh, sorry. I understand your problem now. Because the state item in the discord should be at least two word, your change will still be failed on my case. However, I don't have the album in your case. I want to ask the If we know the answer, we can further solve this issue. |
70ed6e8 to
ce5ad0e
Compare
|
Update: I make a little change and it still works on my case. |
Because Discord needs state string's length at least two, we add padding for the album's name is only one character
ce5ad0e to
822ef83
Compare
|
Ok, I think if both of us cases work, you can merge it if there is no problem anymore. XD |
Merged, thanks for the pull request! |




Some albums' name only have 1 character. However, discord's status have to be at least two characters.
Therefore, we add 1 space padding for this case.