specifies that shell commands should be executed always with bash#483
Open
gjlondon wants to merge 1 commit intojtriley:developfrom
Open
specifies that shell commands should be executed always with bash#483gjlondon wants to merge 1 commit intojtriley:developfrom
gjlondon wants to merge 1 commit intojtriley:developfrom
Conversation
…d the sgeadmin default shell to zsh which was returning a 1 code when it failed to find .json files in while globiing for old profiles to remove. no reason to just not use bash for these commands to behavior is predictable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had changed the sgeadmin default shell to zsh, which was causing a crash when starting up the ipython notebooks because the script globs for json files and, finding none, zsh a 1 code which kills the script. Bash just hums along and finishes.