feat(macos): support mouse wheel input in defsrc#2010
Merged
jtroo merged 1 commit intojtroo:mainfrom Apr 8, 2026
Merged
Conversation
Extend the existing mouse event tap to also intercept `ScrollWheel`
events and decode them into `MouseWheel{Up,Down,Left,Right}` OsCodes,
mirroring the axis/sign convention from `OsKbdOut::scroll`. Pick the
dominant axis on diagonal scrolls (vertical wins ties), matching how
Linux processes one `REL_WHEEL/REL_HWHEEL` at a time. Suppress mapped
wheel directions and forward them as `KeyValue::Tap` events; pass
unmapped ones through
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes. Use imperative present tense.
Extend the existing mouse event tap to also intercept
ScrollWheelevents and decode them into
MouseWheel{Up,Down,Left,Right}OsCodes,mirroring the axis/sign convention from
OsKbdOut::scroll. Pick thedominant axis on diagonal scrolls (vertical wins ties), matching how
Linux processes one
REL_WHEEL/REL_HWHEELat a time. Suppress mappedwheel directions and forward them as
KeyValue::Tapevents; passunmapped ones through
Checklist