fix(parser): restore default key mappings on clear#2012
Merged
jtroo merged 1 commit intojtroo:mainfrom Apr 9, 2026
Merged
Conversation
clear_custom_str_oscode_mapping wipes the global string-to-OsCode map including defaults like ';' -> KEY_SEMICOLON, then releases the lock before parse_cfg calls replace_custom_str_oscode_mapping to re-add them. Concurrent str_to_oscode callers in parallel tests can observe the gap and fail to resolve literal punctuation keys, surfacing as a flaky 'unknown key' error on slower CI runners Re-install the defaults inside clear_custom_str_oscode_mapping under the same lock so the global never has a default-less window
jtroo
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes. Use imperative present tense.
clear_custom_str_oscode_mapping wipes the global string-to-OsCode map including defaults like ';' -> KEY_SEMICOLON, then releases the lock before parse_cfg calls replace_custom_str_oscode_mapping to re-add them. Concurrent str_to_oscode callers in parallel tests can observe the gap and fail to resolve literal punctuation keys, surfacing as a flaky 'unknown key' error on slower CI runners
Re-install the defaults inside clear_custom_str_oscode_mapping under the same lock so the global never has a default-less window
Checklist