feat(macos): support mouse-movement-key#2014
Merged
jtroo merged 1 commit intojtroo:mainfrom Apr 11, 2026
Merged
Conversation
Lift the parser and live-reload cfg gates to include macOS, and extend the existing CGEventTap to also tap `MouseMoved` and `*MouseDragged` events. On each cursor movement (drags included), emit a synthetic `KeyValue::Tap` of the configured `OsCode` without suppressing the underlying event, mirroring the Linux event-loop branch Read the configured key live through a shared `Arc<Mutex<Option<OsCode>>>` so live-reload changes take effect with no extra plumbing. Extend the existing install gate to also install the tap when only `mouse-movement-key` is set (no defsrc mouse buttons) Add a parser regression test for the new cfg gate
jtroo
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes. Use imperative present tense.
Lift the parser and live-reload cfg gates to include macOS, and extend
the existing CGEventTap to also tap
MouseMovedand*MouseDraggedevents. On each cursor movement (drags included), emit a synthetic
KeyValue::Tapof the configuredOsCodewithout suppressing theunderlying event, mirroring the Linux event-loop branch
Read the configured key live through a shared
Arc<Mutex<Option<OsCode>>>so live-reload changes take effect with noextra plumbing. Extend the existing install gate to also install the tap
when only
mouse-movement-keyis set (no defsrc mouse buttons)Add a parser regression test for the new cfg gate
Checklist