Skip to content

Enable selection handler property to be populated via selection-model-handle-events attribute #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

avassilev-odbg
Copy link

Description:

We need this update in order to trigger selection on different events.
With this change you can specify them in the 'selection-model-handle-events' attribute.
It is evaluated by the selectionModel directive.

Example:

<li data-ng-repeat="child in parent" data-selection-model data-selection-model-handle-events="'click mousedown'" ></li>

Notes:
The attribute value is evaluated by the directive, so you need to specify it in single quotes for strings or provide a getter function.

@jtrussell
Copy link
Owner

This seems like a useful feature. I'd love to add it but would you mind including some tests? Also, I might be wrong but I think the events should maybe be space separated instead of comma separated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants