api/v2: expose other known device IPs - #3419
Open
bigbozza wants to merge 2 commits into
Open
Conversation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #2272
Summary
Headscale stores the latest endpoint set reported by each node, but this
information is not available through the API.
Add
otherKnownIPsto the API v2 Device response. The field contains theunique IP addresses from the node's last reported endpoints, excluding its
Headscale-assigned tailnet addresses.
Endpoint ports are omitted because the field represents known addresses rather
than connection endpoints. Results are sorted for deterministic responses, and
nodes without known endpoints return an empty array.
No persistence or migration changes are required.
Testing
exclusion, and empty endpoint sets.