Skip to content

Linux: Fix FileChooser ignoring the initial directory with zenity #1678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emezeske wants to merge 1 commit into
base: develop
Choose a base branch
from
+16 −3
Open

Linux: Fix FileChooser ignoring the initial directory with zenity #1678

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions modules/juce_gui_basics/native/juce_FileChooser_linux.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,10 +265,23 @@ class FileChooser::Native final : public FileChooser::Pimpl,
else
File::getSpecialLocation (File::userHomeDirectory).setAsCurrentWorkingDirectory();

auto filename = owner.startingFile.getFileName();
// zenity needs an absolute path in --filename: a bare relative name is
// ignored and the dialog falls back to $HOME. For a directory, a trailing
// separator tells zenity to open inside it rather than selecting it within
// its parent.
String startPath;

if (! filename.isEmpty())
args.add ("--filename=" + filename);
if (owner.startingFile.isDirectory())
startPath = File::addTrailingSeparator (owner.startingFile.getFullPathName());
else if (owner.startingFile.getParentDirectory().exists())
startPath = owner.startingFile.getFullPathName();
else if (owner.startingFile.getFileName().isNotEmpty())
startPath = File::getSpecialLocation (File::userHomeDirectory)
.getChildFile (owner.startingFile.getFileName())
.getFullPathName();

if (startPath.isNotEmpty())
args.add ("--filename=" + startPath);

// supplying the window ID of the topmost window makes sure that Zenity pops up..
if (uint64 topWindowID = getTopWindowID())
Expand Down