Fix: coerce NaN to None for optional string fields in TransactionObject#147
Open
edbyford wants to merge 1 commit intojuftin:mainfrom
Open
Fix: coerce NaN to None for optional string fields in TransactionObject#147edbyford wants to merge 1 commit intojuftin:mainfrom
edbyford wants to merge 1 commit intojuftin:mainfrom
Conversation
When the Lunch Money API returns null for optional string fields (category_name, recurring_payee, recurring_cadence, recurring_type, recurring_currency, recurring_description), these can arrive as NaN floats rather than None, causing Pydantic validation to fail. This adds a field_validator that coerces NaN values to None, similar to the fix applied in juftin#113 for the Assets model. Fixes juftin#146 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
field_validatortoTransactionObjectthat coercesNaNfloat values toNonefor optional string fields (category_name,recurring_payee,recurring_cadence,recurring_type,recurring_currency,recurring_description)nullfor these fields, they can arrive asNaNfloats (e.g. via pandas), causing Pydantic validation to fail withInput should be a valid string [type=string_type, input_value=nan, input_type=float]Fixes #146
Test plan
lunchable plugins primelunchagainst a Lunch Money account with uncategorised transactions or transactions without recurring fieldsValidationError🤖 Generated with Claude Code