Fix: Refactor to avoid clippy::needless_for_each warning in derive(OpenApi) #1423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enApi) By refactoring the macro to generate a for loop instead of using for_each, we now produce code that is cleaner and no longer triggers this clippy warning.
|
@juhaku Can you take a look at this? |
|
For anyone that wants to use this until it gets merged, add the following to your [patch.crates-io]
# https://github.com/juhaku/utoipa/pull/1423
utoipa = { git = "https://github.com/raimannma/utoipa.git", rev = "47aa9ff215db156b6cfe687cab858360c6fe4275" } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a small change to the
utoipa-gen/src/openapi.rsfile. The change replaces the use of.iter().for_eachwith aforloop for iterating over modifiers in theToTokensDiagnosticsimplementation forOpenApi.Closes #1420