Attempt to fix tests for 'repr' feature - #1583
Open
fnimick wants to merge 1 commit into
Open
Conversation
Note that the tests do not pass as is, as the api docs generated for a 'tagged repr enum' do not appear to match serde_repr's runtime behavior, as validated inline in the test.
Contributor
There was a problem hiding this comment.
please insta accept the snapshots and commit the result. .new is just the proto-snapshot and needs to be renamed first
Author
There was a problem hiding this comment.
This is the one where the generated openapi doesn't match the serde_repr runtime behavior, so the snapshot output here is wrong (potentially). That's why I left it in this state.
Author
There was a problem hiding this comment.
@CommanderStorm I wasn't sure what to do here in the case where I'm not sure whether an existing behavior is a bug or not, as I've never used repr enums but the output seems to not make sense. Should I open an issue?
Contributor
There was a problem hiding this comment.
if the behaviour is wrong, that would be best.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that the tests do not pass as is, as the api docs generated for a 'tagged repr enum' do not appear to match serde_repr's runtime behavior, as validated inline in the test.
Please do not merge!