feat: reactive on 26.04#696
Open
sabaini wants to merge 6 commits into
Open
Conversation
Signed-off-by: Peter Sabaini <peter.sabaini@canonical.com>
Signed-off-by: Peter Sabaini <peter.sabaini@canonical.com>
Signed-off-by: Peter Sabaini <peter.sabaini@canonical.com>
Signed-off-by: Peter Sabaini <peter.sabaini@canonical.com>
Signed-off-by: Peter Sabaini <peter.sabaini@canonical.com>
Contributor
Author
|
charmcraft currently blocks reactive charms on 26.04 -- i have exercised this PR with a local charmcraft which has the block removed |
Contributor
Author
|
also cf. canonical/charmcraft#2678 |
freyes
requested changes
Apr 29, 2026
| # rest of the dependency set. | ||
| pip install \ | ||
| --no-binary :all: \ | ||
| --only-binary virtualenv,distlib,filelock,platformdirs,python-discovery \ |
Collaborator
There was a problem hiding this comment.
this will break (most likely) some of the not so common architectures we support, e.g. ppc64el and s390x
Contributor
Author
There was a problem hiding this comment.
Ok I've now switched to core24 so we get a newer python3-pathspec, this otherwise breaks hatchling
Also had to introduce Cython min. version as this would otherwise break
Signed-off-by: Peter Sabaini <peter.sabaini@canonical.com>
Contributor
Author
|
@freyes I believe the charmcraft changes have landed now in canonical/charmcraft#2678 so tests should have a better chance of passing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reactive plugin support for 26.04