Skip to content

feat(ci): disable relations ci tests #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gfouillet
Copy link
Contributor

relation ci tests are disable for 4.0 until the related epic will be finished.

  • deploy once validated

relation ci tests are disable for 4.0 until the related epic will be finished.
condition-kind: not
condition-operand:
condition-kind: regex-match
regex: "^[5-9].*|^4\\.([0-9]|\\d{{2,}})(\\.|-).*"
Copy link
Contributor Author

@gfouillet gfouillet Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jack-w-shaw This generated regexp looks suspicious to me. Why do we have double braces around the \d specifier ?

(it comes from this code you initiate a year ago ;)

var minVersionRegex = map[string]string{
"3.0": "^[4-9].*|^3\\\\.([0-9]|\\\\d{{2,}})(\\\\.|-).*",
"3.1": "^[4-9].*|^3\\\\.([1-9]|\\\\d{{2,}})(\\\\.|-).*",
"3.2": "^[4-9].*|^3\\\\.([2-9]|\\\\d{{2,}})(\\\\.|-).*",
"3.3": "^[4-9].*|^3\\\\.([3-9]|\\\\d{{2,}})(\\\\.|-).*",
"3.4": "^[4-9].*|^3\\\\.([4-9]|\\\\d{{2,}})(\\\\.|-).*",
"3.5": "^[4-9].*|^3\\\\.([5-9]|\\\\d{{2,}})(\\\\.|-).*",
"3.6": "^[4-9].*|^3\\\\.([6-9]|\\\\d{{2,}})(\\\\.|-).*",
"4.0": "^[5-9].*|^4\\\\.([0-9]|\\\\d{{2,}})(\\\\.|-).*",
}
)

It should be:

Suggested change
regex: "^[5-9].*|^4\\.([0-9]|\\d{{2,}})(\\.|-).*"
regex: "^[5-9].*|^4\\.([0-9]|\\d{2,})(\\.|-).*"

What do I miss ?

Copy link
Contributor Author

@gfouillet gfouillet Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@jack-w-shaw jack-w-shaw Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll have to ask @hpidcock about the double-bracketing

I would be opposed to replacing [0-9] with \d in these places, because the lines below we have [1-9], [2-9], etc., so [0-9] is much more readable line-to-line

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{var} is a jenkins job builder template variable substitution
{{}} is escaped by jenkins job builder to be {}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants