Prevented crash from faulty data - #9
Open
MightbeMagic wants to merge 1 commit into
Open
Conversation
Chess.js library returns a location string with only a number and causes the player to be locked with the piece, not letting them move it at all. This code checks if the string is the correct length before allowing it through in hideMoves and showMoves to prevent the error from being thrown, as it runs just fine so long as that faulty object is excluded.
|
this is the correct solution, should be merged to master |
xorozo
approved these changes
Dec 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chess.js library returns a location string with only a number and causes the player to be locked with the piece, not letting them move it at all. This code checks if the string is the correct length before allowing it through in hideMoves and showMoves to prevent the error from being thrown, as it runs just fine so long as that faulty object is excluded.