fix(ci): resolve lint error and sync embedded formulas#63
Closed
julianknutsen wants to merge 1 commit intomainfrom
Closed
fix(ci): resolve lint error and sync embedded formulas#63julianknutsen wants to merge 1 commit intomainfrom
julianknutsen wants to merge 1 commit intomainfrom
Conversation
Fix two CI failures on main: - Fix gosec G115 (int -> uint32 overflow) in namepool.go by converting uint32 hash to int instead of int length to uint32 - Regenerate mol-deacon-patrol.formula.toml to sync with source formulas Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Code Coverage ReportOverall Coverage: 20.3%
Generated by CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix two CI failures that have been breaking main for ~3 weeks.
Related Issue
No specific issue — all CI runs on main since Jan 19 have been failing.
Changes
internal/polecat/namepool.go:381: Convertedhash(uint32) tointinstead of convertinglen(themes)(int) touint32, avoiding the integer overflow conversion that gosec flags.go generate ./internal/formula/...to syncmol-deacon-patrol.formula.tomlwith its source in.beads/formulas/. The source had updated the costs-digest step but the embedded copy was stale.Testing
go test ./...)golangci-lint run ./...passes with 0 issuesgo generate ./internal/formula/...produces no further diff (formulas stable)go build ./cmd/gtsucceedsChecklist
🤖 Generated with Claude Code