Skip to content

fix(ci): resolve lint error and sync embedded formulas#63

Closed
julianknutsen wants to merge 1 commit intomainfrom
fix/ci-lint-and-formula-sync
Closed

fix(ci): resolve lint error and sync embedded formulas#63
julianknutsen wants to merge 1 commit intomainfrom
fix/ci-lint-and-formula-sync

Conversation

@julianknutsen
Copy link
Copy Markdown
Owner

Summary

Fix two CI failures that have been breaking main for ~3 weeks.

Related Issue

No specific issue — all CI runs on main since Jan 19 have been failing.

Changes

  • Fix gosec G115 lint error in internal/polecat/namepool.go:381: Converted hash (uint32) to int instead of converting len(themes) (int) to uint32, avoiding the integer overflow conversion that gosec flags.
  • Regenerate embedded formulas: Ran go generate ./internal/formula/... to sync mol-deacon-patrol.formula.toml with its source in .beads/formulas/. The source had updated the costs-digest step but the embedded copy was stale.

Testing

  • Unit tests pass (go test ./...)
  • golangci-lint run ./... passes with 0 issues
  • go generate ./internal/formula/... produces no further diff (formulas stable)
  • go build ./cmd/gt succeeds

Checklist

  • Code follows project style
  • Documentation updated (if applicable)
  • No breaking changes (or documented in summary)

🤖 Generated with Claude Code

Fix two CI failures on main:

- Fix gosec G115 (int -> uint32 overflow) in namepool.go by converting
  uint32 hash to int instead of int length to uint32
- Regenerate mol-deacon-patrol.formula.toml to sync with source formulas

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown

Code Coverage Report

Overall Coverage: 20.3%

Package Coverage
cmd/gt 0.0%
internal/activity 100.0%
internal/agent 86.7%
internal/beads 27.2%
internal/boot 0.0%
internal/checkpoint 94.6%
internal/claude 0.0%
internal/cmd 9.6%
internal/config 68.2%
internal/connection 21.5%
internal/constants 0.0%
internal/crew 34.6%
internal/daemon 9.4%
internal/deacon 31.4%
internal/deps 39.6%
internal/dog 0.8%
internal/events 0.0%
internal/feed 67.3%
internal/formula 68.2%
internal/git 29.2%
internal/keepalive 60.7%
internal/lock 84.4%
internal/mail 36.0%
internal/mayor 0.0%
internal/mq 100.0%
internal/opencode 76.9%
internal/plugin 37.9%
internal/polecat 32.8%
internal/protocol 81.4%
internal/refinery 17.4%
internal/rig 41.6%
internal/runtime 82.9%
internal/session 76.6%
internal/shell 61.8%
internal/state 67.6%
internal/style 2.0%
internal/suggest 97.1%
internal/swarm 13.8%
internal/templates 31.0%
internal/tmux 34.0%
internal/townlog 46.9%
internal/tui/convoy 0.0%
internal/tui/feed 0.0%
internal/ui 13.5%
internal/util 47.1%
internal/version 0.0%
internal/web 26.4%
internal/wisp 80.7%
internal/witness 19.1%
internal/workspace 45.8%
internal/wrappers 0.0%

Generated by CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant