Skip to content

optimize_clear_loop bail early if instructions struct too small #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rwhitworth wants to merge 1 commit into
base: master
Choose a base branch
from
Open

optimize_clear_loop bail early if instructions struct too small #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion optimize.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,9 @@ bool optimize_compress_PTR(INSTRUCTIONS *instructions, int *position, CODE *code
bool optimize_clear_loop(INSTRUCTIONS *instructions, int *position, CODE *code) {
if (globalOptions.optimize < 2) // Only do on optimization level 2 and higher
return false;

if (instructions->size - (*position) < 3)
Copy link
Owner

@julianneswinoga julianneswinoga Jul 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the 3 to be based on the number of characters being checked? I.e. sizeof(clearLoop) - 1?

return false;

char clearLoop[] = "[-]";
int i;
for (i = 0; i < sizeof(clearLoop) - 1; i++) {
Expand Down