Skip to content

[Android] Optimize Secure Storage by Replacing Single Worker Thread with Thread Pool #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[Android] Optimize Secure Storage by Replacing Single Worker Thread with Thread Pool #906

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
569ff1d
Use a thread pool instead of a single worker thread
farmery Mar 8, 2025
e7b45a6
cap thread count
farmery Mar 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions .../android/src/main/java/com/it_nomads/fluttersecurestorage/FlutterSecureStoragePlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package com.it_nomads.fluttersecurestorage;

import android.os.Handler;
import android.os.HandlerThread;
import android.os.Looper;

import androidx.annotation.NonNull;
Expand All @@ -10,6 +9,8 @@
import java.io.StringWriter;
import java.util.HashMap;
import java.util.Map;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;

import io.flutter.embedding.engine.plugins.FlutterPlugin;
import io.flutter.plugin.common.MethodCall;
Expand All @@ -21,30 +22,30 @@ public class FlutterSecureStoragePlugin implements MethodCallHandler, FlutterPlu

private MethodChannel channel;
private FlutterSecureStorage secureStorage;
private HandlerThread workerThread;
private Handler workerThreadHandler;
private ExecutorService executor;
private FlutterPluginBinding binding;

@Override
public void onAttachedToEngine(FlutterPluginBinding binding) {
this.binding = binding;
workerThread = new HandlerThread("fluttersecurestorage.worker");
workerThread.start();
workerThreadHandler = new Handler(workerThread.getLooper());
int availableCores = Runtime.getRuntime().availableProcessors();
int threadCount = Math.min(4, Math.max(2, availableCores));
this.executor = Executors.newFixedThreadPool(threadCount);

channel = new MethodChannel(binding.getBinaryMessenger(), "plugins.it_nomads.com/flutter_secure_storage");
channel.setMethodCallHandler(this);
}

@Override
public void onDetachedFromEngine(@NonNull FlutterPluginBinding binding) {
if (channel != null) {
if (workerThread != null) {
workerThread.quitSafely();
workerThread = null;
}
channel.setMethodCallHandler(null);
channel = null;
}
if (executor != null) {
executor.shutdown();
executor = null;
}
secureStorage = null;
}

Expand All @@ -69,7 +70,7 @@ private boolean initSecureStorage(Result result, Map<String, Object> options) {
@Override
public void onMethodCall(@NonNull MethodCall call, @NonNull Result rawResult) {
MethodResultWrapper result = new MethodResultWrapper(rawResult);
workerThreadHandler.post(new MethodRunner(call, result));
executor.execute(new MethodRunner(call, result));
}

class MethodRunner implements Runnable {
Expand Down