-
-
Notifications
You must be signed in to change notification settings - Fork 625
fix: nv21 update #1533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: nv21 update #1533
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1533 +/- ##
========================================
Coverage 38.35% 38.35%
========================================
Files 42 42
Lines 996 996
========================================
Hits 382 382
Misses 614 614
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@navaronbracke i seem to be getting some weird artifacts in the returnImage. Can you maybe check if you're having the same issue? Maybe it's something related to my test device. |
|
I'll check on this branch |
|
@navaronbracke I've updated the format back to yuv, and used the built in I think it's ready to merge, and would be a nice update since it removes all deprecated renderscript api's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! This needs a changelog update, too?
Since camera2 1.5.0, the analysis input can be NV21. This means we can directly convert the image to bitmap, and remove the deprecated renderscript API.
Fixes #1142
Can be merged after #1530