Skip to content

Conversation

@yujune
Copy link

@yujune yujune commented Oct 2, 2025

✨ What's the context?

Fixes a “half‑stopped” state in MobileScannerPlugin where either device or captureSession could remain non-nil after stop/pause or failed start, causing subsequent start calls to throw ALREADY_STARTED_ERROR and potentially leaking resources.

For example, if captureSession is instantiated but device is not, the early return from guard let device... will cause unrelease of captureSession.

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.35%. Comparing base (250bea4) to head (f1b04e8).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1547   +/-   ##
========================================
  Coverage    38.35%   38.35%           
========================================
  Files           42       42           
  Lines          996      996           
========================================
  Hits           382      382           
  Misses         614      614           
Flag Coverage Δ
unittests 38.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Owner

@juliansteenbakker juliansteenbakker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me!

@juliansteenbakker juliansteenbakker merged commit 7ef6118 into juliansteenbakker:develop Oct 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants