fix: handle errors from cvcreatepixelbuffer #1564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navaronbracke
commented
Oct 21, 2025
| // FlutterTexture | ||
| public func copyPixelBuffer() -> Unmanaged<CVPixelBuffer>? { | ||
| if latestBuffer == nil { | ||
| guard let buffer = latestBuffer else { |
There was a problem hiding this comment.
Just in case, also use a guard let here
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1564 +/- ##
===========================================
- Coverage 38.45% 38.35% -0.11%
===========================================
Files 42 42
Lines 996 996
===========================================
- Hits 383 382 -1
- Misses 613 614 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
navaronbracke
commented
Oct 21, 2025
| func updateScanWindow(_ call: FlutterMethodCall, _ result: @escaping FlutterResult) { | ||
| let argReader = MapArgumentReader(call.arguments as? [String: Any]) | ||
| let scanWindowData: Array? = argReader.floatArray(key: "rect") | ||
| let scanWindowData: [CGFloat]? = argReader.floatArray(key: "rect") |
There was a problem hiding this comment.
This was indeed [CGFloat]? in the arg reader
navaronbracke
commented
Oct 21, 2025
|
|
||
| DispatchQueue.main.async { | ||
| // If the image is nil, use zero as the size. | ||
| guard let image = cgImage else { |
There was a problem hiding this comment.
This check is no longer needed
|
@juliansteenbakker I would like to release this as the definitive |
juliansteenbakker
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1545