Skip to content

fix wordgraph bug: 'wordgraph_check_coherence' will check wordgraph f… #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix wordgraph bug: 'wordgraph_check_coherence' will check wordgraph f… #124

wants to merge 1 commit into from

Conversation

@xiaowenth
Copy link

I notice function 'wordgraph_compaction_thesame_sub' has a bug.

  1. before delete we(wordgraph), we's leftwords and rightwords will be added to wg, except for each of them is equal wg. that's to say selfloop is not allowed
  2. when replacing we with wg by checking we's leftwords and rightwords, selfloop is allowed(otherwise leftwords or rightwords may pointer to a deleted we);
    so wordgraph_check_coherence will check failed because of the previous operations

fix wordgraph bug: 'wordgraph_check_coherence' will check wordgraph f…
e1c85ad 
…ailed, if wordgraph has loop after 'merge_contexts' 'swap_rightword' or 'swap_leftword' in wordgraph_compaction_thesame_sub
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@xiaowenth